Check all the iruby examples and a minor change in a CSS example in HighCharts

SciRuby / daru-view

daru-view is for easy and interactive plotting in web application & IRuby notebook. daru-view is a plugin gem to the existing daru gem.

https://sciruby.github.io/daru-view/

MIT License

95 stars 20 forks source link

Check all the iruby examples and a minor change in a CSS example in HighCharts #121

Closed Prakriti-nith closed 5 years ago

Prakriti-nith commented 5 years ago

Run-all all the IRuby examples to ensure that nothing is breaking.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 679

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.044%

Totals
Change from base Build 677:	0.0%
Covered Lines:	3208
Relevant Lines:	3272

💛 - Coveralls

Shekharrajak commented 5 years ago

Note : Has to finish before new release : https://github.com/SciRuby/daru-view/pull/123

Prakriti-nith commented 5 years ago

I just did a minor change in the CSS examples in this PR and re-run all the examples again. I think this is complete.

Shekharrajak commented 5 years ago

I just did a minor change in the CSS examples in this PR

I didn't see new commit @Prakriti-nith . Are that changes just for you?

Prakriti-nith commented 5 years ago

@Shekharrajak I did the change in the original commit of the PR. While moving the CSS, modules and chart_class options to the third parameter, I forgot to do the same in one of the examples of CSS, I have corrected that in this PR.

Shekharrajak commented 5 years ago

Thanks @Prakriti-nith , for update. After https://github.com/SciRuby/daru-view/pull/119 we will merge this.

Shekharrajak commented 5 years ago

@Prakriti-nith , is it good to merge ?

Prakriti-nith commented 5 years ago

@Shekharrajak Yes, it can be merged.