Replaced shekharrajak with 'sciruby' - Githubissues

SciRuby / daru-view

daru-view is for easy and interactive plotting in web application & IRuby notebook. daru-view is a plugin gem to the existing daru gem.

https://sciruby.github.io/daru-view/

MIT License

95 stars 20 forks source link

Replaced shekharrajak with 'sciruby' #135

Closed snpd25 closed 5 years ago

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 772

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.001%) to 98.118%

Totals
Change from base Build 761:	-0.001%
Covered Lines:	3128
Relevant Lines:	3188

💛 - Coveralls

snpd25 commented 5 years ago

And also the link for the website in the "Description" bar needs to be changed to https://sciruby.github.io/daru-view/

Shekharrajak commented 5 years ago

And also the link for the website in the "Description" bar needs to be changed to https://sciruby.github.io/daru-view/

Yes! actually https://sciruby.com/ will redirect to https://sciruby.github.io/ only.

Let me know if you are planning to update any other files as well.

Shekharrajak commented 5 years ago

Also please follow https://github.com/SciRuby/daru-view/wiki/Development-Workflow-and-Contribution-guide#basic-development-flow

Squash the commit (Don't use same commit message again and again).
PR description and refer the issue number your fixing.

snpd25 commented 5 years ago

I was talking about https://shekharrajak.github.io/daru-view/ to be changed to https://sciruby.github.io/daru-view/

Shekharrajak commented 5 years ago

Yes

Shekharrajak commented 5 years ago

Hi @snpd25 , any update ? To squash commits you just have to use git rebase -i HEAD~5 and save the new commit message.

snpd25 commented 5 years ago

@Shekharrajak , see if anything else is required.

Shekharrajak commented 5 years ago

@snpd25 , It seems you need to understand git branching and merging system properly. Please follow this article or similar article. You can watch related youtube videos as well.

P.S. Please see number of commit which is still 15 (my intention is to reduce it. Redundant commit messages should not be present in history). Please understand version control system and why it is important to have a proper commit message.

snpd25 commented 5 years ago

I sincerely apologize for the inconvenience, actually I missed a step and messed-up my repository. Thus I have created a fresh PR. I hope, you are okay with it.

Shekharrajak commented 5 years ago

No problem @snpd25 ! Mistakes happen at the beginning, but you can revert every change or commit (or the wrong git commands as well). Those wrong steps and commands will help you to learn more about git and the features git provides.

Meanwhile, you can try to come back to initial stage without losing your changes. It is not difficult and 100% possible.

snpd25 commented 5 years ago

Thanks @Shekharrajak, I will surely try to improve by exploring more about git and will avoid these mistakes in future.