removed the duplicate highcharts.css

SciRuby / daru-view

daru-view is for easy and interactive plotting in web application & IRuby notebook. daru-view is a plugin gem to the existing daru gem.

https://sciruby.github.io/daru-view/

MIT License

95 stars 20 forks source link

removed the duplicate highcharts.css #145

Closed snpd25 closed 5 years ago

snpd25 commented 5 years ago

References to other Issues or PRs

Fixes #128

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 782

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.005%) to 98.118%

Totals
Change from base Build 780:	-0.005%
Covered Lines:	3128
Relevant Lines:	3188

💛 - Coveralls

Shekharrajak commented 5 years ago

Hi @snpd25 , can you please run all the examples in IRuby notebook (specs/dummy_iruby) and check to make sure whether it is fine or not (you don't need to commit those)?

Thanks for the PR!

snpd25 commented 5 years ago

I have run all the examples in IRuby Notebook, and found these issue: #130 and #146 . Rest everything was working fine.

Shekharrajak commented 5 years ago

@snpd25 , Thanks for update.

I have run all the examples in IRuby Notebook, and found these issue: #130 and #146 . Rest everything was working fine.

I have already replied to query in #130 , I don't know what problem you are facing.

I personally feel that you should mention the things/query properly.

snpd25 commented 5 years ago

@Shekharrajak , sorry for the inconvenience, I commented the problem there. But I feel that these issues do not rise due to the removal of the highcharts.css file , as I checked the examples with having the duplicate file, and it worked the same.