search

SciRuby / daru-view

daru-view is for easy and interactive plotting in web application & IRuby notebook. daru-view is a plugin gem to the existing daru gem.
https://sciruby.github.io/daru-view/
MIT License
95 stars 20 forks source link

Get rid of testcase option - update googlechart/highchart js,css file #160

Closed Shekharrajak closed 3 years ago

Shekharrajak commented 4 years ago

We don't always want to run the update googlechart/highchart js,css file testcase that should be run by only travis for CI/CD.

Screenshot 2020-10-03 at 12 34 29 AM

We ned an option while running rspec locally to skip this test case.

sayant1204 commented 3 years ago

@Shekharrajak, We can add the tag for running testcases locally and modify the update_spec file accordingly. Something like bundle exec rspec --tag ~local which will exclude updating googlechart/highchart file. WDYT?

Shekharrajak commented 3 years ago

Hi @sayant1204 ,

That is good idea. Can you please try it once and open a PR accordingly.

sayant1204 commented 3 years ago

Hello @Shekharrajak,

I solved this issue on my local repository but I am facing some issues while trying to commit this on Github. Some files are not included in .gitignore and are not on the repository itself but were created or modified while running test cases like - .rb file in adapter folder and plot.html file and vendor folder(which will be fixed with this issue). Should I include them in my git exclude file? Since I am new to this open-source and this codebase I am having trouble understanding this.

Another doubt (not related to this issue) is how can we visualize our changes in the iruby notebook?

Shekharrajak commented 3 years ago

yeah, we can add the generated files in .gitignore file. Also we can have a command to tag (annotation) to skip the testcases that generate the files (that will be tested by CI/CD tool anyways so we can have option for skipping them in local machine).

Another doubt (not related to this issue) is how can we visualize our changes in the iruby notebook?

I did not get what you want to visualize. You can run the iruby notebook (check the development workflow, contribution section, setup IRuby notebook and try running them locally).

sayant1204 commented 3 years ago

Hi @Shekharrajak,

In the linked pull request #162, I am getting rubocop errors which I think are due to the updated version of rubocop. I solved them locally. Should I commit them in this issue itself? Other than that I am also getting errors in Travis command bundle exec rake coveralls:push which I am unable to debug. Can you please guide me?

Shekharrajak commented 3 years ago

. Should I commit them in this issue itself

Yes!

Shekharrajak commented 3 years ago

Other than that I am also getting errors in Travis command bundle exec rake coveralls:push which I am unable to debug. Can you please guide me?

Please paste the error in PR