Closed lokeshh closed 7 years ago
How about include_values?
and not_include_values?
? That way it's consistent with Array#include?
and the extra _values
conveys that the behavior differs a little from the Array#include?
. @zverok?
What it will return? If arrays of booleans -- then I still don't think that "predicate method sign" (?
) is appropriate.
@zverok it will return arrays of booleans. Yeah it makes sense to not have the ?
.
Hey, guys, are we going to finalize this eventually? :) I think that we can at least go with nils
/not_nils
or existance(*values)
/non_existance(*values)
. Or whatever!
Yeah lets stick with include_values
.
We already have include_values?
to return true
and false
. I think it will be confusing to have include_values
. Lets's have is_values
. It also signifies that we are checking if the value is the same as what we are passing as argument, "include" could be confusing here. WDYT
We already have include_values? to return true and false. I think it will be confusing to have include_values. Lets's have is_values. It also signifies that we are checking if the value is the same as what we are passing as argument, "include" could be confusing here. WDYT
Ah yes. is_values?
seems like a good choice. @zverok ?
To be honest, I like neither, but can't come with a better name :) So, let's go with is_values
!
Works. is_values?
is the way to go.
Just without question mark, I thought we've agreed on that ;)
@lokeshh can you fix this? The PR is quite old.
Done finally. No more delay :)
Fixes #141
Replaces Vector#is_nil? and Vector#not_nil? with something else.