Filtering out 'vendor' from coverage targets

SciRuby / daru

Data Analysis in RUby

BSD 2-Clause "Simplified" License

1.04k stars 140 forks source link

Filtering out 'vendor' from coverage targets #249

Closed yui-knk closed 8 years ago

v0dro commented 8 years ago

What does this change do exactly?

yui-knk commented 8 years ago

I first bundle install --path vendor/bundle. And then I run tests locally. In this situation, before this commit, simplecov also calculates coverages for files which are located under vendor/bundle.

2016-09-10 1 48 43

This commit prevent simplecov calculating to coverages for files located under vendor/bundle.

zverok commented 8 years ago

@v0dro I think I can understand it. In some Bunlder global settings, it creates local gem cache in current project, and it is in ./vendor/bundle folder. (I have this setting some time ago, it is somewhat convenient, but creates unexpected complications sometimes, like described above)

v0dro commented 8 years ago

Ok works.