SciRuby / daru

Data Analysis in RUby
BSD 2-Clause "Simplified" License
1.04k stars 140 forks source link

Add imagemagick in daru development guide #296

Closed lokeshh closed 7 years ago

lokeshh commented 7 years ago

In order to install rmagick gem (dependency for daru) I had to execute the following command

sudo apt-get install libmagickwand-dev imagemagick

I think it will be good to be added it in the contributing guide.

zverok commented 7 years ago

/me looks at sciruby-dev mailing list Perfect timing :)

Though, what do you think of making all external library dependencies optional even for development? I can see both pro and contra this approach. Pro: some novice/student can try to fix some small bug/propose feature without thinking of "how do I install RMagick" (which, FYI, is pretty tricky on Windows). Contra: this student, in fact, can break something that only on Gruff plotting is visible...

v0dro commented 7 years ago

@zverok how would the dependencies be removed without depending on gruff? I say test the whole gem in one go so that everything stays in order and nothing breaks.

zverok commented 7 years ago

Well, The Ultimate Solution will be gems separation into daru-core, daru-plotting, daru-gsl and so on :) But I am not sure whether it worth trying :)