Closed athityakumar closed 7 years ago
Tests, as in using Travis CI or test-unit
gem?
@athityakumar I've meant specs -- there are ton of them & you can run them locally by just rspec
or rspec path/to/your/spec.rb
@athityakumar I suggest you first go through the CONTRIBUTING file and understand our processes properly before submitting PRs. We're all volunteers and it saves our time if you abide by some formal processes.
Also, submitting a PR without tests is not acceptable. Especially if you want to apply for GSOC.
@v0dro : Thanks for mentioning about the CONTRIBUTING.md
file - I just read through it. I'll add the tests in a day, after including the other missing data types and let you know for reviewing the PR again.
@v0dro @zverok : The PR is ready for another review.
(1) Thanks for the rspec
and rubocop
references. They really made testing the changes simpler.
(2) Support added for other missing data types like Float:NAN
and Float:NAN in string
.
(3) Tests have been written for Daru::Vector#where
and Daru::DataFrame#where
.
Any changes required?
@zverok : I've added the specific test that would have failed on the current master branch version of daru
. As suggested, I've also added my test variables in let
format - however, it does seem a bit different / inconsistent with the rest of the tests in the spec/core/query_spec.rb
file, as they don't use let
format.
however, it does seem a bit different / inconsistent with the rest of the tests in the spec/core/query_spec.rb file, as they don't use let format.
Yes, part of the specs are just old and written without much attention. We want to have them rewritten in modern style with time, yet it was not done yet.
@v0dro @zverok : Made the required changes in tests. :smile:
Fixes issue #246. Sample output for the building pass is shown below.
Ping @v0dro @zverok @lokeshh - Please review this PR when you're free. :smile: