Closed Shekharrajak closed 7 years ago
when I do bundle exec rspec
in my system I don't get any error. I didn't understand this travis failure.
Also I don't find these errors :
/spec/vector_spec.rb:1397 # Daru::Vector#is_values single value to_a should eq [true, false, true, false, false]
rspec ./spec/vector_spec.rb:1403 # Daru::Vector#is_values multiple values to_a should eq [true, false, true, true, true]
in spec/vector_spec.rb:1397
and 1403
line I don't find those lines.
@Shekharrajak looks like some Travis flakiness (maybe due to those S3 problems, that ruined half-the-internet yesterday?) Now it shows "There was an error while loading data." :man_facepalming:
Try rerun build? (Commit something dummy, or close and reopen PR)
Thanks @zverok , I have closed and reopen the PR.
Travis is ill now :( https://www.traviscistatus.com Let's wait. I'll review the PR in the meantime
@zverok , I have updated the PR branch(rebase with upstream/master) and fixed the error.
@zverok ,I think this PR is good to go.
Fixes https://github.com/SciRuby/daru/issues/246