search

SciRuby / daru

Data Analysis in RUby
BSD 2-Clause "Simplified" License
1.04k stars 139 forks source link

Adds default order for Daru::DataFrame (issue #130) #329

Closed athityakumar closed 7 years ago

athityakumar commented 7 years ago

Rspec test added, has been written in the older format to main consistency. This will be easier to change while re-writing all tests to modern specifications file-wise, rather than modernizing specs for individual functions. RDoc documentation has also been added.

Tackles issue #130

athityakumar commented 7 years ago

@zverok @v0dro - After closer inspection of the logs of the last successful build and current failing build of master branch in Travis CI, I observe that bundle install used to install rubocop v0.47.1 (build passing) and is now installing rubocop v0.48.0 (build failing). Have a look at the respective releases of rubocop gem.

We can specify rubocop (~>= 0.47.1) in the Gemfile.lock and remove the Gemfile.lock from .gitignore. Do you think this would fix the build error, or could it be something else?

zverok commented 7 years ago

We can specify rubocop (~>= 0.47.1) in the Gemfile.lock and remove the Gemfile.lock from .gitignore. Do you think this would fix the build error, or could it be something else?

Instead of that, we can fix current rubocop version offences on each PR. They are reasonable, and being a small project we can't expect dedicated volunteers to "update rubocop" in separate PR. So whoever met new offences first is that unfortunate person who fixes them :)

zverok commented 7 years ago

(but you can exclude Rakefile and Gemfile from rubocop-checked files, of course)

athityakumar commented 7 years ago

@zverok - Alright, I'm taking one for the team. :)

Rubocop offenses are fixed, and build is finally successful. It does feel good to see the Build passing and green tick again. :tada: