search

SciRuby / daru

Data Analysis in RUby
BSD 2-Clause "Simplified" License
1.04k stars 139 forks source link

Adds Daru::Vector#match and Daru::Vector#apply_where (issue #175) #333

Closed athityakumar closed 4 years ago

athityakumar commented 7 years ago

Rspec test added, has been written in the older format to main consistency. This will be easier to change while re-writing all tests to modern specifications file-wise. RDoc documentation has also been added. Daru::Vector#match uses Regexp match via the =~ operator.

Tackles issue #175

athityakumar commented 7 years ago

@v0dro @zverok @lokeshh - Following the discussions on the issues #175 and #174 , #match support has been provided only to Daru::Vector. Please review this PR. :smile:

athityakumar commented 7 years ago

@zverok @v0dro : Just wanted to remind you about this PR - kindly review whenever you're free. :slightly_smiling_face:

zverok commented 7 years ago

Reviewing it now.

v0dro commented 7 years ago

Whats the update with the PR?

v0dro commented 7 years ago

Please finish it off ASAP.

athityakumar commented 6 years ago

@zverok - Please review when you're free. 😄

v0dro commented 6 years ago

I think @zverok is busy with refactoring :P