SciRuby / daru

Data Analysis in RUby

BSD 2-Clause "Simplified" License

1.04k stars 139 forks source link

[#242] Added error stream to daru #343

Closed sivagollapalli closed 7 years ago

sivagollapalli commented 7 years ago

242

sivagollapalli commented 7 years ago

@zverok I thought that I have to use on https://github.com/SciRuby/daru/blob/master/lib/daru.rb#L87 to silence that warning, but since it is an installation error I thought it would be better to show. And also on remaining code base I didn't see any STDERR.puts statements. So I didn't make any changes. If you want to silence the error message I would really happy to make that change.

v0dro commented 7 years ago

Here's how you can proceed:

Set the error_stream default to STDERR.
Change all calls to STDERR in the code base to @@error_stream.
Write tests accordingly.

sivagollapalli commented 7 years ago

@v0dro Since I didn't know how to test spreadsheet dependency in spec so I avoided that. Could you give suggestions regarding that?

sivagollapalli commented 7 years ago

@zverok Added changes. Could you please check?

sivagollapalli commented 7 years ago

@zverok Incorporated the changes. Could you please check?