search

SciRuby / daru

Data Analysis in RUby
BSD 2-Clause "Simplified" License
1.03k stars 139 forks source link

return Nyaplot plot instance instead of nil. #350

Closed Shekharrajak closed 7 years ago

Shekharrajak commented 7 years ago

This will help me to use the Nyaplot plot object for further configuration like weight, height, etc in daru-view : https://github.com/Shekharrajak/daru-view/pull/3 .

IRuby notebook will still display plot.

Shekharrajak commented 7 years ago

Ping @zverok @v0dro @lokeshh

v0dro commented 7 years ago

@Shekharrajak can you confirm that you've checked that this works in iRuby? I'm good with this change if yes.

Shekharrajak commented 7 years ago

@v0dro ,Yes I have checked it. It is working fine.

v0dro commented 7 years ago

Ok. Let @zverok approve and we can merge.

Shekharrajak commented 7 years ago

Ping @v0dro