search

SciRuby / daru

Data Analysis in RUby
BSD 2-Clause "Simplified" License
1.03k stars 139 forks source link

[#354] Vector::lag supports -ve shift. tests updated. #355

Closed parthm closed 7 years ago

parthm commented 7 years ago

This has the fix for #354 Tests have been updated. Comments / suggestions welcome.

v0dro commented 7 years ago

Looks good. Just resolve the rubocop offences and I'll merge.

parthm commented 7 years ago

Rubocop offenses resolved. Pretty much the only way to resolve ABC size too high was to break up the function. Added additional test cases for lag 0.

parthm commented 7 years ago

@zverok Please let me know if the code / test are OK to merge now. Thanks for your earlier inputs. The code and test certainly look much cleaner now.