search

SciRuby / daru

Data Analysis in RUby
BSD 2-Clause "Simplified" License
1.03k stars 139 forks source link

[#356] proposed patch to support histogram in Daru::Vector#macd #357

Closed parthm closed 7 years ago

parthm commented 7 years ago

Vector#macd updated to return [macdseries, macdsignal, macdhist]. Added tests. Docs updated for the change and to be in line with yard format. Suggestions / comments welcome.

parthm commented 7 years ago

@zverok Please let me know if the tests look OK now or if something can be improved further.

parthm commented 7 years ago

Thanks for the inputs @zverok . Custom matcher :be_all_within was a great idea. It can probably be used in other tests as well for comparing float arrays. Please let me know if the macd tests look good now.

parthm commented 7 years ago

Thanks for the inputs @zverok . Does this look better.