Closed rainchen closed 6 years ago
cc @v0dro
@zverok it's easy to see the code changes and CI failures using a PR. And as I mentioned, if someone can point out some key tips I can have a try. If some one get this bug fixed, I can close this PR.
@rainchen can you also open an issue that talks of this issue? When people see a PR they assume that someone is working on it. Moreover they need to pull your branch for a very minor change when they just copy-paste the failing test from the issue. You can just paste the failing code in the issue and the error that you received along with that (unless of course you will be finishing this PR).
@v0dro I did it :) https://github.com/SciRuby/daru/issues/390
@v0dro it's kind for the long explanation, I'm just being lazy :).
@zverok thx for the action :)
Its just a few lines of code that you add to the issue instead of the specs.
Here is the failure details of test:
the
@data
is nil after callingdv.to_category
I found this bug, but it is out of my knowledge of daru's source codes, I'm not sure how to fix it. Someone can fix it? Or point out some key tips I can have a try.