Closed tramuntanal closed 6 years ago
Aknowledged. It is nasty bag, caused by backports gem requireing. Unfortunately, it is not that easy to fix: backports required not only in daru itself, but also in packable
gem, required by nmatrix
. I've did a PR to packable, but I am not sure when it could be merged :( Only after that we can proceed with fixing the bug.
Issue has been solved by removing backports dependency.
Ugh. We can't mark this issue as a resolved. I should've mark corresponding PR as WIP, sorry :( The problem describe in this comment:
It is nasty bag, caused by backports gem requireing. Unfortunately, it is not that easy to fix: backports required not only in daru itself, but also in packable gem, required by nmatrix. I've did a PR to packable, but I am not sure when it could be merged :( Only after that we can proceed with fixing the bug.
I provided a PR to original packable
repo, and it was merged, but only after that I've noticed that SciRuby have taken over packable.
So, the course of actions are:
packable
gem according to https://github.com/marcandre/packable/pull/9require 'backports'
we should use something like require 'backports/2.1/hash/to_h'
or something)If you can submit that PR to sciruby/packable I can merge it and release a new version.
Done the PR to SciRuby/packable.
It is fixed in master, I'll release a new minor version soon.
The bug appears in two forms.
If the Matrix was created before requiring 'daru'
colum_size
doesn't work:If the Matrix is created after requiring 'daru'
colum_count
doesn't work:I can't find any reference to
#column_count
or#column_size
in the Daru code.