search

SciRuby / daru

Data Analysis in RUby
BSD 2-Clause "Simplified" License
1.03k stars 139 forks source link

Set index as default x axis for DataFrame #414

Closed matugm closed 6 years ago

matugm commented 6 years ago

Hi, this is my attempt at fixing https://github.com/SciRuby/daru/issues/402.

It breaks one test, but otherwise it seems to work.

If you have a better idea on how to do this let me know :)

v0dro commented 6 years ago

@matugm ping!

matugm commented 6 years ago

Will work on this today.

matugm commented 6 years ago

Ok I made the requested changes. Only thing left is 2 Rubocop warnings.

matugm commented 6 years ago

Ready for review @zverok :)

zverok commented 6 years ago

@matugm But where's any specs for the new behavior?..

matugm commented 6 years ago

Spec added & also tested manually with IRuby.

zverok commented 6 years ago

Thanks!