search

SciRuby / daru

Data Analysis in RUby
BSD 2-Clause "Simplified" License
1.03k stars 139 forks source link

integrated yard-junk into Cl #417

Closed rohitner closed 6 years ago

rohitner commented 6 years ago

issue #399

rohitner commented 6 years ago

@zverok please suggest changes to ignore yard script for ruby 2.0

zverok commented 6 years ago

please suggest changes to ignore yard script for ruby 2.0

Let's try to approach the problem from another side? To include yard-junk script only on ruby-2.4 (because it will produce the same errors on any version of Ruby) And that's also true for Rubocop, BTW

zverok commented 6 years ago

Ah, and you should look at how it fails on Travis. It fails not on script running stage, but on gem installation. It could be easily avoided with if RUBY_VESION >= '2.1' in gemspec

rohitner commented 6 years ago

The problem is that config in the travis build wasn't changed as expected for ruby 2.0, if that is solved, the build can be modified as required.

zverok commented 6 years ago

The problem is that config in the travis build wasn't changed as expected for ruby 2.0, if that is solved, the build can be modified as required.

It was. But before using the config, travis does bundle install. Which tries to install yard-junk, and fails (because gem specifies minimal Ruby version)

rohitner commented 6 years ago

I have changed the build matrix as required.

rohitner commented 6 years ago

@zverok is it okay to allow 2.0 build to fail for now to keep the number of builds intact?

zverok commented 6 years ago

Screw the Ruby 2.0 :)