search

SciRuby / daru

Data Analysis in RUby
BSD 2-Clause "Simplified" License
1.03k stars 139 forks source link

Fix tuple sorter #420

Closed baarkerlounger closed 6 years ago

baarkerlounger commented 6 years ago 
keys = [[" Black and White", nil, 31],[" Black and White", "Rob Marshall", 205]]`
keys.sort(&TUPLE_SORTER)
ArgumentError: comparison of Array with Array failed
zverok commented 6 years ago

will try to stop posting WIP PRs too!

It is not necessary, in fact :) Just include [WIP] in the title of those PRs, and write a comment like "Now it is finished!" when it is :)

baarkerlounger commented 6 years ago

@zverok think this is ready for another look

baarkerlounger commented 6 years ago

@zverok made both suggested changes

baarkerlounger commented 6 years ago

https://github.com/SciRuby/daru/issues/324