prevent drop of default index values

SciRuby / daru

Data Analysis in RUby

BSD 2-Clause "Simplified" License

1.03k stars 139 forks source link

prevent drop of default index values #431

Closed rohitner closed 6 years ago

rohitner commented 6 years ago

made some minor changes for fixing #422

rohitner commented 6 years ago

it checks if the dataframes have same indices and sets the same index in the merged dataframe, which was earlier 0 1 2 3 ..

zverok commented 6 years ago

Yes, I've almost guessed :) But any bugfix should first have a showcase of problem fixed in specs. It is important, because any behavior not shown in specs can be easily broken again on the next iteration.

rohitner commented 6 years ago

@zverok is this the right way?

rohitner commented 6 years ago

done! learning a lot these days by contributing :smile: