Closed paisible-wanderer closed 6 years ago
Thanks! And sorry for long wait.
There was a method access_row_tuples_by_indexs
in dataframe.rb
which has been recently removed from daru. This method has been used extensively in daru-view, so it is creating problems in the visualization with GoogleCharts and HighCharts when data is provided as Daru::DataFrame. @zverok @paisible-wanderer is there any alternative method provided or should we add it again?
@zverok no problem, I am happy that it was finally merged!
PR for Issue 453
It might be easier to review commit by commit
I think that the main contribution is the method
Daru::DateFrame#group_by_and_aggregate
, here are some benchmarks: (nowhere extensive)1/ comparaison of groupping + aggregation - on my PR
2/ I end up refactoring the groupping method (will be a bit slower)
=========================
Please, let me know if there is anything I can improve.