search

SciRuby / daru

Data Analysis in RUby
BSD 2-Clause "Simplified" License
1.03k stars 139 forks source link

move annoying gem install msgs to postinstall msg #457

Closed IsmailM closed 6 years ago

IsmailM commented 6 years ago

See #404

Messages about optional gems should not be shown each time Daru is loaded.

These messages have been added to the post-install message - this way if anyone is interested in these optional gems, they can install them then...

v0dro commented 6 years ago

I'm ok with this. @zverok ?

v0dro commented 6 years ago

@IsmailM can you fix the rubocop offenses?

IsmailM commented 6 years ago

Hey @v0dro,

Thanks for the quick response, I have 'fixed' the rubocop offenses

PS. Rubocop doesn't like empty rescuing blocks - as such, I've disabled the Lint/HandleExceptions rubocop for this section. Let me know if you prefer something else.

IsmailM commented 6 years ago

Hey @v0dro , @zverok ,

Any Updates?

zverok commented 6 years ago

@IsmailM I've just pushed an alternative solution to master, so I am closing this. Sorry for it taking too long, it is my fail to move towards new version :(

IsmailM commented 6 years ago

Hey @v0dro, @zverok

Thanks once again for sorting this out and pushing a solution to the master branch.

Any chance you could release a newer gem update so that the updated version can be used in StatSample?

Kind Regards, Ismail Moghul