search

SciRuby / daru

Data Analysis in RUby
BSD 2-Clause "Simplified" License
1.04k stars 140 forks source link

Remove unused variables #520

Closed laser-shark closed 4 years ago

laser-shark commented 5 years ago

I noticed some warnings about these unused variables while using daru in a project and wanted to remove them. :)

kojix2 commented 5 years ago

As you can see in the Travis CI test results, these variables are used in ERB. That's why you can't delete these variables. But it doesn't mean there's no need for improvement. If Rubocop misunderstands the variables are not used, it's probably not good for humans to read too.

laser-shark commented 5 years ago

Sorry, I didn't realize this! I guess it's not that hard to understand for someone who knows ERB. To be honest, I don't really have an idea on how to make this better, other than maybe disabling the rubocop rule for these methods?

Shekharrajak commented 5 years ago

Sorry, I didn't realize this! I guess it's not that hard to understand for someone who knows ERB. To be honest, I don't really have an idea on how to make this better, other than maybe disabling the rubocop rule for these methods?

These variables are needed.

Shekharrajak commented 5 years ago

Please let me know if you need more clarification.

v0dro commented 4 years ago

Closing due to inaction.