search

SciRuby / distribution

Probability distributions for Ruby.
http://sciruby.com/
Other
50 stars 21 forks source link

Remove reference to deprecated Fixnum #41

Closed kaiuhl closed 6 years ago

kaiuhl commented 6 years ago

Hi friends.

There's an unnecessary reference to a now-deprecated class (Fixnum) in a method to do math I don't understand that you fine folks wrote years ago that I need for calculating whether my a/b tests work.

This fixes it! There's no other references to Fixnum elsewhere and the type check wasn't useful anyway, so please merge it. I updated the History and bumped the version and everything.

👏

kaiuhl commented 6 years ago

Thanks @vaibhav-y! :taco:

kaiuhl commented 6 years ago

Hey @vaibhav-y, will you please push the new version to rubygems?

envp commented 6 years ago

Unfortunately, I am not in that group. @mohawkjohn @agarie @clbustos may have those permissions?

patrickdet commented 6 years ago

oh that would be great!

translunar commented 6 years ago

I think it's going to have to wait until next week. My laptop is in the shop and I'm on a different machine. Maybe @clbustos can do it if you can get his attention.

Is there some reason you need it pushed to rubygems urgently? Is the Gemfile not working properly / allowing you to do a local require?