search

SciRuby / iruby

Official gem repository: Ruby kernel for Jupyter/IPython Notebook
https://github.com/SciRuby/iruby
MIT License
890 stars 27 forks source link

Make application/javascript a text type #294

Closed mrkn closed 3 years ago

mrkn commented 3 years ago

While mime-types handles application/javascript as a non-text, IRuby needs to handle it as a text.

The new ascii? private method judges whether the given mime type is text. This method handles application/javascript as a text in the special case.

[Fix GH-292]

kojix2 commented 3 years ago

I should have suqash and merge... 😓

mrkn commented 3 years ago

I don't like squash and merge because it does not mark the branch in the local working copy as merged.