search

SciRuby / iruby

Official gem repository: Ruby kernel for Jupyter/IPython Notebook
https://github.com/SciRuby/iruby
MIT License
901 stars 29 forks source link

Include date in headers #340

Closed rgbkrk closed 3 months ago

rgbkrk commented 5 months ago

When testing out this kernel with https://github.com/zed-industries/zed/pull/12062, I noticed that date is not in the headers. I'd love to see that added in so that I don't have to make date optional in my rust structures.

kojix2 commented 5 months ago

Hi @rgbkrk

Thank you for your report. IRuby currently has no active developers and has no plans to keep up with the latest Jupyter protocol. Still, I would like to hear a little more detail on your report.

If I understand correctly, you are reporting that the Message Header does not contain a date field, right?

Maybe we can modify the code here to add a date field...

https://github.com/SciRuby/iruby/blob/f341266ea123a0a916b17b148742bb101b6c0a41/lib/iruby/session.rb#L79-L85

rgbkrk commented 5 months ago

You don't have to implement all the messages, but I'd at least bring it up to version 5.1 compliance where date is a required field. https://jupyter-client.readthedocs.io/en/latest/messaging.html

rgbkrk commented 4 months ago

Thank you @ebababi! @kojix2, who has the ability to ship a patch release of the gem for iruby?

kojix2 commented 4 months ago

The owners of the gem are @minad, @mrkn, @domitry, @v0dro, and @kozo2.

kozo2 commented 3 months ago

@kojix2 Can I ask you to ship that release? I invited you to the owner of https://rubygems.org/gems/iruby .

kojix2 commented 3 months ago

Sure, @kozo2. Thank you for the invitation. I will review the changes and would like to proceed with shipping the release soon.

kojix2 commented 3 months ago

Version 0.8.0 has been uploaded to the rubygem server. There may still be room for improvement. If you find ways to improve it, pull requests are welcome.