search

SciRuby / iruby

Official gem repository: Ruby kernel for Jupyter/IPython Notebook
https://github.com/SciRuby/iruby
MIT License
901 stars 29 forks source link

Add logger and Remove base64 to Fix CI Tests #345

Closed kojix2 closed 4 months ago

kojix2 commented 4 months ago

Hi

The current CI fails tests with the latest version of Ruby, specifically debug. To pass these tests, the following two fixes are necessary:

  1. Remove the unnecessary require "base64"

This may be code intended for future changes, but it is not currently used. From Ruby 3.4, base64 will no longer be a default gem.

  1. Add logger to dependencies

From Ruby 3.5, logger will also no longer be a default gem, so it needs to be explicitly specified as a dependency.

By applying these fixes, the tests will pass. The minor goal of this pull request is to pass the tests. However, the larger goal is to maintain a state where contributors can easily submit their pull requests.