search

SciRuby / iruby

Official gem repository: Ruby kernel for Jupyter/IPython Notebook
https://github.com/SciRuby/iruby
MIT License
901 stars 29 forks source link

Suppress "literal string will be frozen in the future" warning #353

Closed tikkss closed 1 month ago

tikkss commented 1 month ago

Before change:

$ rake 2>&1 | grep 'iruby.*frozen'
/Users/zzz/src/github.com/SciRuby/iruby/lib/iruby/formatter.rb:128: warning: literal string will be frozen in the future
/Users/zzz/src/github.com/SciRuby/iruby/lib/iruby/formatter.rb:96: warning: literal string will be frozen in the future

After change:

$ rake 2>&1 | grep 'iruby.*frozen'
kojix2 commented 1 month ago

Thanks! Good catch!

tikkss commented 1 month ago

Thanks for your review!

kojix2 commented 1 month ago

You're welcome. Please send us a pull request again anytime.