search

SciRuby / nmatrix

Dense and sparse linear algebra library for Ruby via SciRuby
Other
469 stars 133 forks source link

Update rspec dependency #413

Open v0dro opened 8 years ago

v0dro commented 8 years ago

Why is RSpec still at 2.14 in nmatrix? Any specific reason?

I think we should update it to 3.4 (latest).

wlevine commented 8 years ago

Well, we get a ton of warnings about using deprecated RSpec features that will behave differently in RSpec 3. So we would need to change a bunch of tests.

v0dro commented 8 years ago

Is that it?

I think I can do the needful whenever I get some free time.

lokeshh commented 8 years ago

@v0dro Are you on it? If you are not working on this issue let me know. I am interested in doing this.

v0dro commented 8 years ago

Well I'll take some time (~2 weeks). If you're going to do this right away then feel free to do so :)

lokeshh commented 8 years ago

Ok you do it. I will find something else to work upon.

translunar commented 8 years ago

Is there some reason we need the additional features in 3.4? It isn't always beneficial to change a gem dependency. There should be a motivation behind such a change.

v0dro commented 8 years ago

It shows a whole load of deprecation warnings regarding change of syntax.

v0dro commented 8 years ago

Related to #294

translunar commented 6 years ago

Looks like rspec-longrun now supports rspec 3.x, so we can go ahead with upgrading to a newer rspec. :)

https://github.com/mdub/rspec-longrun/issues/5#issuecomment-132267353