Closed wlevine closed 8 years ago
Why are the tests failing?
@v0dro Looks like the failures relate to #522 and #538, or at least resemble those. I can't see how any of @wlevine's changes would have caused this, though — can you?
@mohawkjohn I think you're right. Those other bugs will need fixing for the build to pass.
@wlevine Can you please rebase against master? I think we've fixed the Travis problems.
@mohawkjohn Done!
This partly fixes #541. Here are the results of Lokesh's benchmark with the patch:
#[]
is probably fast enough now.#[]=
is a lot faster than before, but may still need more work.@mohawkjohn I think this is the right way to do this, but I'd appreciate it if you take a look.