search

SciRuby / nmatrix

Dense and sparse linear algebra library for Ruby via SciRuby
Other
469 stars 133 forks source link

JRuby port of NMatrix #558

Closed prasunanand closed 7 years ago

prasunanand commented 7 years ago

rake spec leads to no failure

prasunanand commented 7 years ago

Need help here: https://github.com/prasunanand/nmatrix/blob/0eb5fc5907ced23a6d12e4fae1a4c379d9e202fc/travis.sh#L128

prasunanand commented 7 years ago

Travis tests for JRuby pass and removed from "allowed failures" :) . Please review.

wlevine commented 7 years ago

One concern: the dtype argument is totally ignored. I understand that currently only doubles are supported, but an error should be thrown if I try to create a matrix with an unsupported dtype. The same with stype. You should refuse to create a matrix if someone specifies an stype other than :dense.

wlevine commented 7 years ago

It seems like rake package is broken on your branch.

v0dro commented 7 years ago

Finally this is merged! Congratulations @prasunanand =)