search

SciRuby / nmatrix

Dense and sparse linear algebra library for Ruby via SciRuby
Other
469 stars 133 forks source link

Adding user specified seed value: fix for #566 #579

Closed Shailesh-Tripathi closed 7 years ago

Shailesh-Tripathi commented 7 years ago

@mohawkjohn I did a few more changes in the function definition and in spec file. bundle exec rake spec running with no failures. I was not quite sure about the spec so please check it.

translunar commented 7 years ago

What are you not quite sure about with regards to the spec?

Shailesh-Tripathi commented 7 years ago

@mohawkjohn Can I check something like: m1=Nmatrix.random(x1) m2=Nmatrix.random(x2) Now if x1==x2 m1should be=m2 otherwise different. I think this test is fair.

translunar commented 7 years ago

@shailesh210 That test sounds like a good one to me. :) Go ahead and add that in when you have a minute and I'll review again.

translunar commented 7 years ago

Sorry for the double-review, couldn't figure out how to revise the old one to mark as changes-requested.

Shailesh-Tripathi commented 7 years ago

Can anybody help with this. Why did the travis build failed at a point where I did not make any change. The changes made by me ran fine but it broke somewhere else. In my local repo 'bundle exec rake spec' runs fine.

Thanks in advance !

translunar commented 7 years ago

@shailesh210 You're almost there, don't quit now. :)

Shailesh-Tripathi commented 7 years ago

Hi @mohawkjohn Sorry, I was actually bust these two days :) I asked a few doubts there. Please reply! :)

translunar commented 7 years ago

Merged as https://github.com/SciRuby/nmatrix/commit/cfadf50593c49a8849aef77abf194c937861a08e