Remove needless macro existence checks

SciRuby / nmatrix

Dense and sparse linear algebra library for Ruby via SciRuby

Other

469 stars 133 forks source link

Closed kou closed 7 years ago

kou commented 7 years ago

Macro existence can be checked by #ifndef and nmatrix.h already does.

translunar commented 7 years ago

Uggh, a failing test on JRuby. Anyone know the reason why? I think we can merge this anyway. The failure is almost certainly unrelated.

kou commented 7 years ago

Anyone know the reason why?

Because #561 doesn't include JRuby implementation of #positive_definition?.

translunar commented 7 years ago

@v0dro Can you please review and merge if it satisfies you?

v0dro commented 7 years ago

This is satisfactory. Merging.