Closed Uditgulati closed 5 years ago
@Shekharrajak I've made some changes. Kindly have a look and let me know if anything else needs to be changed.
@Shekharrajak Hi, I think we should merge this PR now as it does fix most of builds. It'll help prevent errors in user builds on systems with compatibly issues due to old versions.
Actually, we need to look into https://travis-ci.org/SciRuby/nmatrix/jobs/501367373 this travis failure as well. I think @prasunanand can review it better.
Fixes:
Also, updated the corresponding ruby 2.1.x, 2.2.x, 2.3.x, 2.4.x to latest versions and removed non-clang and osx pairs.
There is still some exception (Illegal seek -) generated in some linux builds while running tests that needs to be fixed. I'll try to fix that too and make a different PR for that.