search

SciRuby / nmatrix

Dense and sparse linear algebra library for Ruby via SciRuby
Other
469 stars 133 forks source link

Fix gcc capability check #632

Open plprofetes opened 3 years ago

plprofetes commented 3 years ago

Current implementation supports g++ 4.x only, when checking c++11 support.

Fix assumes that any g++ newer than 4 does support c++11.

It allows compiling nmatrix on modern g++ versions.

fixes #630

mishelhiti commented 4 months ago

hey, can you please share if there is a way to install this gem with your fix besides waiting for it to merge to main?

KirtashW17 commented 4 months ago

hey, can you please share if there is a way to install this gem with your fix besides waiting for it to merge to main?

Hi, You could install the gem from github adding this to your Gemfile:

gem 'nmatrix', git: 'https://github.com/plprofetes/nmatrix' # plprofetes version

or https://github.com/SciRuby/nmatrix/pull/633

gem 'nmatrix', git: 'https://github.com/KirtashW17/nmatrix_gpp10' # my version

mishelhiti commented 4 months ago

Sorry for not knowing this but where is the Gemfile located? like what is the full set of cmds i need to run on windows to make it work?

KirtashW17 commented 4 months ago

If you use Bundler, your Ruby project will have a Gemfile in the root that specifies all the dependencies of your project. If you're trying to globally install the gem, you could try to follow the steps mentioned here: https://stackoverflow.com/a/2577404

  1. Clone plprofetes or my repo
  2. run gem build nmatrix.gemspec
  3. run gem install nmatrix-0.2.4.gem
mishelhiti commented 4 months ago

didn't work... how did you managed to bypass the gcc version check?