search

SciRuby / nmatrix

Dense and sparse linear algebra library for Ruby via SciRuby
Other
469 stars 133 forks source link

Made installation work with gpp10+ (version > 10) #633

Closed KirtashW17 closed 2 years ago

KirtashW17 commented 2 years ago

I recently had to install nmatrix gem in a machine with gpp14 running and I noticed that the installation failed because was comparing the version as a string. I fixed it making the function gplusplus version to return an array of numbers instead of a string, and changing the if conditions.

EDIT: I just noticed that there is already a Pull Requests solving this issue, but i think both PR can be merged since one fixes the find_newer_gplusplus method and another the conditionals checking the version.

fixes #630

KirtashW17 commented 2 years ago

Duplicated of #632

mishelhiti commented 4 months ago

hey, is there a way to install the gem with this fix? i'm having problems installing the gem because i have gcc14.1.0

KirtashW17 commented 4 months ago

hey, is there a way to install the gem with this fix? i'm having problems installing the gem because i have gcc14.1.0

Hi, You could install your the from github adding this to your Gemfile:

gem 'nmatrix', git: 'https://github.com/KirtashW17/nmatrix_gpp10' # my version

or #632

gem 'nmatrix', git: 'https://github.com/plprofetes/nmatrix' # plprofetes version