@iamrajiv Thanks for the PR. I see that the binary file lib/nmatrix.bundle is also included. I believe this file is generated during compilation and should not be part of source code, please remove it.
Don't write the content in comments format as it does not show up in the parsed Markdown file. The formatting also need some fixing. Since no other SciRuby project has a PR template, try looking at how some other open source projects have written it. And the template needs not to be long as it's not a big project yet, so having only a few rules should be fine.
Uditgulati
commented
3 years ago
@iamrajiv Thanks for the PR. I see that the binary file
lib/nmatrix.bundleis also included. I believe this file is generated during compilation and should not be part of source code, please remove it.Don't write the content in comments format as it does not show up in the parsed Markdown file. The formatting also need some fixing. Since no other SciRuby project has a PR template, try looking at how some other open source projects have written it. And the template needs not to be long as it's not a big project yet, so having only a few rules should be fine.