Implemented upper and lower triangle methods in NumRuby

SciRuby / numruby

Fast Numerical Linear Algebra Library for Ruby. NMatrix reimplementation.

BSD 3-Clause "New" or "Revised" License

45 stars 10 forks source link

Implemented upper and lower triangle methods in NumRuby #45

Closed iamrajiv closed 3 years ago

iamrajiv commented 4 years ago

Fixes: #29

Uditgulati commented 4 years ago

@iamrajiv Add some tests. Also, indentation needs to be fixed.

Uditgulati commented 4 years ago

@iamrajiv pls have a look at the suggestions.

Uditgulati commented 4 years ago

@iamrajiv tests are failing, there seems to be some syntax errors. Make sure to run tests first before committing.

developerfab commented 4 years ago

to resolve the test, I think you could change the Capital Letter in the parameters by lower case, because ruby take the capital letter like a constant. WDYT?