search

SciRuby / rubex

rubex - A Ruby-like language for writing Ruby C extensions.
BSD 2-Clause "Simplified" License
451 stars 21 forks source link

Some ruby-style refactorings #32

Closed tessi closed 6 years ago

tessi commented 6 years ago

While reading through the ruby sources of this gem I did some walk-by refactorings to make the ruby sources read more like the ruby style guide recommends.

It is mostly:

If you find this helpful I might follow-up with a PR which integrates rubocop, a highly configurable ruby code linter.

For me (running ruby 2.3.1) the tests do not pass in master nor in my branch. My branch doesn't add any more rspec failures -- it should not change any code semantics.

shaunakpp commented 6 years ago

Hi @tessi, awesome job! Regarding test failures, are you by any chance using macOS?

tessi commented 6 years ago

Thanks!

yes, I'm on macOS. Can I somehow make things work?

tessi commented 6 years ago

Oh, I just saw https://github.com/SciRuby/rubex/issues/31. This might explain the failures