search

SciRuby / ruby-sparse

Ruby Library for Sparse Tensors
BSD 3-Clause "New" or "Revised" License
4 stars 1 forks source link

Added RuboCop static code analyzer #12

Open iamrajiv opened 3 years ago

iamrajiv commented 3 years ago

Fixes: #4

Uditgulati commented 3 years ago

Fix the RuboCop test and get the whole thing to work locally (also post some evidence that it works fine like screenshots or some output that RuboCop gives) then put a comment that it's done, I'll have a look then.

Ignore the ruby-head test, it's failing in the repo too.

iamrajiv commented 3 years ago

@Uditgulati I think RuboCop linter is failing because GitHub token is not set for Ruby-Sparse repository.

Shekharrajak commented 3 years ago

Why few checks failed ? Can you please have a look

iamrajiv commented 3 years ago

@Shekharrajak Ruby-Sparse test / test (ubuntu, head) test is failing in the repo too and I think RuboCop linter / lint is failing because the GitHub token is not set for Ruby-Sparse repository.

Shekharrajak commented 3 years ago

@Shekharrajak Ruby-Sparse test / test (ubuntu, head) test is failing in the repo too and I think RuboCop linter / lint is failing because GitHub token is not set for Ruby-Sparse repository.

Do we have open issue for this ? If not, then please open one so that we can track it and someone pick this task.

iamrajiv commented 3 years ago

@Shekharrajak I have opened an issue #13 on Ruby-Sparse test / test (ubuntu, head) test.