Closed v0dro closed 9 years ago
Hey Sameer, can you remove the update to History? I think this kind of update should be made on its own. It's easier to browse the commit log that way.
ok done. Is everything else alright? Is it ok to start with daru now?
Almost. Can you provide a test showing that it's possible to create vectors with the old interface? I'll merge this PR with that in place. Also, it's usually a good idea to use STDERR.puts
instead of plain puts
when printing warnings. Sometimes it doesn't make a difference, but it can avoid some headaches when printing results in a script for a large-y dataset.
With these comments in place---yes, please, let's get started with Daru! :+1:
ok done.
All tests except those that were failing before the change are passing.