search

SciRuby / statsample

A suite for basic and advanced statistics on Ruby.
https://github.com/sciruby/statsample
BSD 3-Clause "New" or "Revised" License
95 stars 29 forks source link

Logit and Probit Regression missing #48

Closed onli closed 8 years ago

onli commented 8 years ago

In the Readme, logit and probit regression are mentioned. But I find them nowhere in the code, only in the form of a comment mention in https://github.com/SciRuby/statsample/blob/master/lib/statsample/regression.rb#L18. Did they get lost, or are they still around somewhere?

v0dro commented 8 years ago

They are in a separate gem statsample-glm.

onli commented 8 years ago

Thanks, that should help. That isn't documented anywhere though, right? Are there plans to merge this, or interest in getting a proposal on how to mention that in the statsample readme? Given that the gem works for me.

v0dro commented 8 years ago

It's going to remain a separate gem so that GLM methods remain abstracted. Will it be possible for you send a PR with updates to the statsample README? I'd be happy to merge it.