`show_progress` non positional argument is defined but not used

SciSciCollective / pyscisci

Science of Science

MIT License

165 stars 22 forks source link

`show_progress` non positional argument is defined but not used #8

Open rodogi opened 3 years ago

rodogi commented 3 years ago

Hi Alex,

The keyword argument show_progress in functions raostriling_interdisciplinarity and field_citation_distance from file measures/raostirling.py is never actually used within those functions. Should we remove it or add an if statement to show the progress when show_progress is equal to True?

Best, Rodrigo

ajgates42 commented 3 years ago

I think for consistency with the other metric functions it would be good to keep the show_progress argument. Would you want to add a few checkpoints to print progress when show_progress=True?

rodogi commented 3 years ago

Sure, I can add that. I'll open a pull request when I have it.