search

SciSharp / TensorFlow.NET

.NET Standard bindings for Google's TensorFlow for developing, training and deploying Machine Learning models in C# and F#.
https://scisharp.github.io/tensorflow-net-docs
Apache License 2.0
3.17k stars 507 forks source link

[BUG Report]: NumPy amin and amax function are incorrectly mapped #1151

Closed OliBomby closed 12 months ago

OliBomby commented 1 year ago

Description

amin and amax are aliases for min and max in numpy. They don't do the same as argmin or argmax. Refer to the documentation: https://numpy.org/doc/stable/reference/generated/numpy.amin.html https://numpy.org/doc/stable/reference/generated/numpy.amax.html

They should map to tf.min and tf.max

Relevant source file: https://github.com/SciSharp/TensorFlow.NET/blob/master/src/TensorFlowNET.Core/NumPy/NumPy.Statistics.cs

Reproduction Steps

use np.amin and notice everything go up in flames

Known Workarounds

No response

Configuration and Other Information

Wanglongzhi2001 commented 12 months ago

Thank you for your kind reminder, I will fix it.

Wanglongzhi2001 commented 12 months ago

Hello, this bug has been fixed.