search

SciSharp / TensorFlow.NET

.NET Standard bindings for Google's TensorFlow for developing, training and deploying Machine Learning models in C# and F#.
https://scisharp.github.io/tensorflow-net-docs
Apache License 2.0
3.23k stars 517 forks source link

[BUG Report]: EarlyStop does not stop #1170

Open asaf92 opened 1 year ago

asaf92 commented 1 year ago

Description

When using EarlyStop and reaching a point where the training should stop, it just repeats the message Restoring model weights from the end of the best epoch: but keeps training.

It looks like it sets stop_training = true correctly, but the value of stop_training is not checked anywhere in FitInternal

Reproduction Steps

No response

Known Workarounds

No response

Configuration and Other Information

No response

Oceania2018 commented 1 year ago

Released v0.110.3. Can you check if this version works?

Wanglongzhi2001 commented 1 year ago

Can this issue be closed? @asaf92

GaijinOtohp commented 1 year ago

Released v0.110.3. Can you check if this version works?

The issue still exists even in v0.110.3. The model keeps training while "EarlyStopping" does triger it by changing "Stop_training" to true.

asaf92 commented 1 year ago

It still exists in v0.110.3 @Wanglongzhi2001

I decompiled and saw that the code wasn't changed