search

SciTools-incubator / iris-esmf-regrid

A collection of structured and unstructured ESMF regridding schemes for Iris.
BSD 3-Clause "New" or "Revised" License
17 stars 16 forks source link

Update lockfiles and fix for new esmpy #342

Closed stephenworsley closed 2 months ago

stephenworsley commented 4 months ago

Replaces #335 and adds a fix.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.85%. Comparing base (94f3e05) to head (7696d49).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #342 +/- ## ======================================= Coverage 98.85% 98.85% ======================================= Files 36 36 Lines 3855 3855 ======================================= Hits 3811 3811 Misses 44 44 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

schlunma commented 2 months ago

Hey @stephenworsley, I just did some updates to my environment and started to see issues like

ValueError: ESMC_MeshAddElement() failed with rc = 509.    Please check the log files (named "*ESMF_LogFile")

when using iris-esmf-regrid. This only appears with esmpy=8.6.1; with esmpy=8.4.2 I don't get this error. Does this PR here fix that? Any chance there will be a new release of iris-esmf-regrid soon? Thanks!!

stephenworsley commented 2 months ago

@schlunma Yes, I believe this should fix this error, I'm thinking of doing a release at some point at the end this month.

valeriupredoi commented 2 months ago

Hey @stephenworsley, I just did some updates to my environment and started to see issues like

ValueError: ESMC_MeshAddElement() failed with rc = 509.    Please check the log files (named "*ESMF_LogFile")

when using iris-esmf-regrid. This only appears with esmpy=8.6.1; with esmpy=8.4.2 I don't get this error. Does this PR here fix that? Any chance there will be a new release of iris-esmf-regrid soon? Thanks!!

saw exactly the same behaviour elsewhere (ANTS) two days ago :+1:

bouweandela commented 2 months ago

I see no changes to the iris-esmf-regrid code in this pull request, only to test infrastructure. How can this fix the issue described by @schlunma and why would a new release help if the released code is identical?

stephenworsley commented 2 months ago

@bouweandela this PR ended up getting split in two. The actual fix went into #353 in order for the benchmarks to be able to run before and after the lockfile update.

bouweandela commented 2 months ago

Thanks, that makes sense. Does the new code work with all versions of ESMPy? Or just 8.6 and up?

schlunma commented 1 week ago

Thanks, that makes sense. Does the new code work with all versions of ESMPy? Or just 8.6 and up?

@stephenworsley sorry to bother you again, but would you know if if this new version is also compatible with ESMPy < 8.6.0?

valeriupredoi commented 1 week ago

Thanks, that makes sense. Does the new code work with all versions of ESMPy? Or just 8.6 and up?

@stephenworsley sorry to bother you again, but would you know if if this new version is also compatible with ESMPy < 8.6.0?

same q from me too, please, folks :beer: