search

SciTools / .github

Organisational level things such as the SciTools README and organisation workflows
BSD 3-Clause "New" or "Revised" License
2 stars 4 forks source link

Pre-commit hook for license headers? #22

Open rcomer opened 9 months ago

rcomer commented 9 months ago

📰 Custom Issue

Over at https://github.com/SciTools/cf-units/pull/364#discussion_r1501764951, @pelson suggested that the test_coding_standards.py module would be better as a pre-commit hook. I found this insert-license is a supported hook.

trexfeathers commented 9 months ago

Interesting idea 🙂. How would you propose converting all the other tests that are in the test_coding_standards module?

rcomer commented 9 months ago

Heh, I hadn't clocked that Iris has other tests in there. cf-units only has the license header test, which is repeated all over SciTools and is going a bit wrong in Cartopy https://github.com/SciTools/cartopy/pull/2278.

rcomer commented 9 months ago

Is there a better place to put issues that affect multiple SciTools repos?

trexfeathers commented 9 months ago

Is there a better place to put issues that affect multiple SciTools repos?

SciTools/.github

rcomer commented 9 months ago

Thanks @trexfeathers - looks like I don't have permissions there so I can't transfer the issue. Please move it if you wish 👍