Closed QuLogic closed 9 years ago
@QuLogic - this looks like the test is fragile to the arch. I suspect the problem is that numpy's int is arch dependent, and at no point are we being specific (https://github.com/SciTools/biggus/blob/master/biggus/tests/unit/test_ConstantArray.py#L74).
The odd thing is that I don't remember the problem occurring when building 0.6.0, but now when I try it, it also fails. I guess I'm just mis-remembering.
Looks like you're correct:
int_ Default integer type (same as C
long
; normally eitherint64
orint32
)
I fixed this test by changing the aforementioned line to this:
- self.assertEqual(array.dtype, np.dtype('i8'))
+ self.assertEqual(array.dtype, np.dtype(np.int_))
@QuLogic - would you mind submitting a PR?
Done.
Thanks @QuLogic!
See this example build:
though I don't seem to see anything that might have changed here.