search

SciTools / biggus

:no_entry: [DEPRECATED] Virtual large arrays and lazy evaluation.
http://biggus.readthedocs.io/
GNU Lesser General Public License v3.0
54 stars 27 forks source link

Test means with different axes. #131

Closed rhattersley closed 9 years ago

pelson commented 9 years ago

Is this testing the functionality in https://github.com/SciTools/biggus/blob/master/biggus/tests/test_aggregation.py#L49?

rhattersley commented 9 years ago

Is this testing the functionality in https://github.com/SciTools/biggus/blob/master/biggus/tests/test_aggregation.py#L49?

If you're asking, "Is the test you've submitted in this PR redundant because of ...#L49?", then the answer is, "No." The test you linked to checks that computing axis=0 causes one pass of the data, and that computing axis=1 causes one pass of the data. The test in this PR checks that both axis=0 and axis=1 can be computed at the same time and still only use one pass of the data.

NB. I was surprised this new test passed!

pelson commented 9 years ago

NB. I was surprised this new test passed!

Very cool :+1: